Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO 7239: support for AWS S3 Multipart Upload #5356

Merged
merged 10 commits into from
Oct 12, 2023
Merged

FIO 7239: support for AWS S3 Multipart Upload #5356

merged 10 commits into from
Oct 12, 2023

Conversation

brendanbond
Copy link
Contributor

@brendanbond brendanbond commented Oct 2, 2023

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7239

Description

This PR

  • adds support for AWS S3 multipart uploads to the File component edit form;
  • adds support for AWS S3 multipart uploads to the S3 file storage provider;
  • somewhat refactors the XHR submodule in the providers module to be more readable;
  • converts provider functions from arrow functions into function statements so they're compatible with the TS build system;

Dependencies

formio-server:#1360

How has this PR been tested?

automated and manual testing

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond marked this pull request as ready for review October 2, 2023 19:04
@TanyaGashtold
Copy link
Contributor

Looks good but please resolve the merge conflicts

@travist
Copy link
Member

travist commented Oct 12, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants