Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9508: Fix vm tests failing #208

Open
wants to merge 1 commit into
base: 2.4.x
Choose a base branch
from

Conversation

mikekotikov
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9508

Description

What changed?

Added case in eachComponentData function to iterate through components of an empty nested array data components in order to fix the vm tests.

Why have you chosen this solution?

The test was failing due to child components of an empty DataGrid were not assigned to the RootShim instanceMap in vm and bc of this none of those components could be got with getComponent()

Breaking Changes / Backwards Compatibility

The fix is done for 2.4.x branch since 2.3.x doesn't have the changes that broke it.

Dependencies

None

How has this PR been tested?

There's a tests in vm repo for this case.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant