FIO-9465: fix conditionals path for panel component #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maria-Golomb
changed the title
brendanbond
requested changes
Dec 30, 2024
| @@ -93,7 +93,10 @@ export const conditionalProcess = (context: ConditionsContext, isHidden: Conditi | |||
| } | |||
| let conditionalComp = scope.conditionals.find((cond) => cond.path === path); | |||
| if (!conditionalComp) { | |||
| conditionalComp = { path, conditionallyHidden: false }; | |||
| conditionalComp = { | |||
There was a problem hiding this comment.
something seems fishy to me about this change. Why wouldn't one of the new pathing options work here for Panel? (i.e. fullPath or fullDataPath etc.)? Can you explain your reasoning here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9465
Description
Fixed path generation (for scope.conditionals) during conditional processing.
The changes allow avoiding the clearing of req.data for situations when wizard form have panels with specified conditionals relying on a component within the form. Unnecessary data clearing couses problems in the validation process of nested forms.
How has this PR been tested?
autotests
manually
Checklist: