Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9357 fixed calculation based on DataSource component #202

Conversation

HannaKurban
Copy link
Contributor

@HannaKurban HannaKurban commented Dec 9, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9357

Description

Previously, the calculation of values on the server side based on the DataSource component did not work correctly, because after fetching data for the dataSource, the data was not saved, and the fetched value included only the Boolean value. Therefore, during the calculation process based on the value of data.dataSource, data.dataSource is undefined. This behavior has been fixed by adding fetched data when calculating process

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

Automated test has been added . All tests pass locally

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@johnformio johnformio merged commit 9e9ce40 into master Dec 16, 2024
8 checks passed
lane-formio pushed a commit that referenced this pull request Jan 8, 2025
* FIO-9357 fixed calculation based on DataSource component

* FIO-9357 fixed typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants