fix: reused instances don't keep cache #731
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
reused instances don't keep cache
explanation: RemoteSourceTrackingService(RSTS) is singleton-by-project.
queryCache is used by
querySourceMembersFrom
For long-running processes (cliaas, vscode, etc) you'd potentially get wrong answers for a project by
60
so it doesn't see the new changes)with this PR, if a new instance of SourceTracking constructs instantiates a RSTS (getting it from the
instanceMap
) it clears the queryCache.Result:
if you keep using the same instance of SourceTracking, the queryCache in RSTS works like current
if you instantiate a new SourceTracking, the queryCache starts empty even if it doesn't have to reconstruct a new RSTS
alternatives considered but rejected
pull
command but it might apply toproject retrieve
🤷What issues does this PR fix or reference?
@W-17609556@