fix: support SF_ env vars
#665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DEPENDS ON: forcedotcom/sfdx-core#1132
The following env vars were being resolved via
@salesforce/kitinstead of sfdx-core:SFDX_SOURCE_TRACKING_BATCH_SIZEit's
SF_version worked by trying to read it first and falling back to theSFDX_one here:source-tracking/src/shared/local/localShadowRepo.ts
Line 55 in 236a0c6
SFDX_SOURCE_MEMBER_POLLING_TIMEOUTnever supported its
SF_version documented here:https://developer.salesforce.com/docs/atlas.en-us.sfdx_setup.meta/sfdx_setup/sfdx_dev_cli_env_variables.htm
This PR makes source-tracking read these via sfdx-core (also added support there in the linked PR above).
Both
SFDX_andSF_should be supported now, no breaking changes.What issues does this PR fix or reference?
@W-16628512@