Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decompose by any folder name #1233

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Feb 8, 2024

What does this PR do?

pulling forward changes from 06afe57 and e43d6f4

(part of larger registryCustomizations work)

needed for
@W-14335636@
@W-13478725@
#1231

before

only fullname is used for the uniqueIdElement
decomposed by folders only use directoryNames

after

uniqueIdElement specified in the registry is used. fullname and name are still the fallbacks when that isn't present
xmlElementName is used when present, directoryName is still the fallback

@mshanemc mshanemc requested a review from a team as a code owner February 8, 2024 19:02
@mshanemc mshanemc requested a review from shetzel February 8, 2024 19:16
@shetzel shetzel merged commit 98901dd into main Feb 8, 2024
69 of 70 checks passed
@shetzel shetzel deleted the sm/decompose-by-any-folder-name branch February 8, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants