Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicates from file responses #1137

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

WillieRuemmele
Copy link
Member

What does this PR do?

removes duplicates from file responses

before:

 ➜  bug sf project deploy start --metadata-dir dup
Debugger listening on ws://127.0.0.1:9229/b0f755b5-6e94-4861-8126-144a41f751ba
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.
Deploying <version specified in manifest> metadata to [email protected] using the v58.0 SOAP API.
Deploy ID: 0Af8N00000uI9ZCSA0
Status: Failed | ████████████████████████████████████████ | 2/2 Components (Errors:2) | 0/0 Tests (Errors:0)
Debugger ending on ws://127.0.0.1:9229/b0f755b5-6e94-4861-8126-144a41f751ba
For help, see: https://nodejs.org/en/docs/inspector

Component Failures [2]
===============================================================
| Type  Name             Problem                    Line:Column 
| ───── ──────────────── ────────────────────────── ─────────── 
| Error GeocodingService Unexpected token 'static'. 2:12        
| Error GeocodingService Unexpected token 'static'. 2:12   

after

 ➜  bug sf project deploy start --metadata-dir dup
Debugger listening on ws://127.0.0.1:9229/9d509851-7f65-44b6-b4ac-2392d048451d
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.
Deploying <version specified in manifest> metadata to [email protected] using the v58.0 SOAP API.
Deploy ID: 0Af8N00000uILdqSAG
Status: Failed | ████████████████████████████████████████ | 2/2 Components (Errors:2) | 0/0 Tests (Errors:0)

Component Failures [1]
===============================================================
| Type  Name             Problem                    Line:Column 
| ───── ──────────────── ────────────────────────── ─────────── 
| Error GeocodingService Unexpected token 'static'. 2:12      

What issues does this PR fix or reference?

@W-14262002@

@WillieRuemmele WillieRuemmele requested a review from a team as a code owner October 11, 2023 17:41
@mshanemc
Copy link
Contributor

had to manually run all the tests here 🤷🏻
https://github.com/forcedotcom/source-deploy-retrieve/actions/runs/6549455042

@mshanemc mshanemc merged commit a8b4ebf into main Oct 17, 2023
59 of 63 checks passed
@mshanemc mshanemc deleted the wr/removeDuplicates branch October 17, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants