fix(deps): testSetup has non ts-sinon dependency #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonnalley
previously approved these changes
Nov 2, 2023
cristiand391
added a commit
to cristiand391/sf-plugin-api
that referenced
this pull request
Nov 5, 2023
* feat: migrate to esm also: * remove swc * bump deps * remove `@salesforce/ts-sinon`, it's no longer required: forcedotcom/sfdx-core#974
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
sfdx-core/testSetup makes use of
ts-sinonforstubMethodbut sfdx-core hasts-sinonin its devDeps. So consumers who want to use testSetup have to know to addts-sinonin their devDeps, and that's not intuitive at all.error looks like
Removes all the use of StubMethod. sfdx-core will still use ts-sinon, but only in tests.
What issues does this PR fix or reference?
[skip-validate-pr]