Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sfdxAuthUrl support port in instanceUrl #1157

Merged
merged 1 commit into from
Nov 13, 2024
Merged

feat: sfdxAuthUrl support port in instanceUrl #1157

merged 1 commit into from
Nov 13, 2024

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

compatibility between authUrl and internal urls (ex: workspaces) that use a port in their instanceUrl
replacement for #388

What issues does this PR fix or reference?

[skip-validate-pr]

@mshanemc mshanemc requested a review from a team as a code owner November 13, 2024 14:06
@mshanemc mshanemc mentioned this pull request Nov 13, 2024
Closed
@shetzel
Copy link
Contributor

shetzel commented Nov 13, 2024

QA

  1. linked this branch to plugin-org and grabbed the auth URL: .../plugin-org/bin/run.js org display -o afdx-core --verbose --json
  2. added the auth url to a file
  3. linked this branch to plugin-auth and did: .../plugin-auth/bin/run.js org:login:sfdx-url -f sfdxAuthUrl.txt -a af
    4 opened an org on my local with: sf org open -o af

@shetzel shetzel merged commit 4df6532 into main Nov 13, 2024
75 checks passed
@shetzel shetzel deleted the sm/port-in-auth-url branch November 13, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillieRuemmele WillieRuemmele WillieRuemmele approved these changes

@shetzel shetzel shetzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshanemc @shetzel @WillieRuemmele @svc-cli-bot