fix: add a did you mean action to AuthInfo

[WillieRuemmele]

What does this PR do?

adds a "did you mean" suggestion to the SfError thrown when we can't find a passed in username/alias when constructing an AuthInfo class.

What issues does this PR fix or reference?

@W-15921235@

[WillieRuemmele]

this was failing to assert the actions[] was equal to the set array, had to break the assertion up

[mdonnalley]

Could it be misleading to tell the user that they mistyped the username or alias? What happens if they provide a username or alias that simply doesn't exist?

Maybe simplifying it to just Did you mean "<suggestion>"? would be the most flexible

Also do we need to remove the action if no suggestion is found?

[WillieRuemmele]

Juliet and I had some back and forth on this. We thought the current messaging was friendlier, but we also had exactly what you suggested 🤷‍♂️

I'll remove it if nothing is passed, or we couldn't deduce any similar names

[mdonnalley]

I'll happily defer to Juliet on the message 👍

[mdonnalley]

is splitting the filename better than getting the username prop from the contents? Or can we not guarantee that that property will be there? More curious than anything

[WillieRuemmele]

yeah, username is optional in the contents

[mdonnalley]

QA

linked sfdx-core to plugin-org and linked plugin-org to sf

Aliases in my env:

Alias List
====================================================
| Alias             Value
| ───────────────── ────────────────────────────────
| 2862              [email protected]
| devhub            [email protected]
| qa                [email protected]
| gh2602            [email protected]
| na40devhub        [email protected]
| scratch-org       [email protected]
| my-org            [email protected]
| v61-custom-object [email protected]
| mdapi-temp-dir    [email protected]

🟢 sf org display -o devhb correctly suggests devhub

Error (2): Parsing --target-org
	No authorization information found for devhb.
See more help with --help

Try this:

It looks like you mistyped the username or alias. Did you mean "devhub"?

🟢 sf org display -o " "

Error (2): Parsing --target-org
	No authorization information found for  .
See more help with --help

Try this:

It looks like you mistyped the username or alias. Did you mean "qa"?

🟢 unset all aliases and then sf org display -o foo

Error (2): Parsing --target-org
	No authorization information found for foo.
See more help with --help

Try this:

It looks like you mistyped the username or alias. Did you mean "[email protected]"?

❓ What are your thoughts on making this a bit smarter? Seems weird to give a username suggestion when the user provided something that doesn't look like a username. Maybe we can check for @ in the string - or maybe that would come back to bite us in some other way?

🔴 unset all aliases and delete all orgs then sf org display -o foo

Error (2): Parsing --target-org
	No authorization information found for foo.
See more help with --help

Try this:

It looks like you mistyped the username or alias. Did you mean ""?

I'd expect this to not suggest anything

[mdonnalley]

See QA

[mdonnalley]

QA #2

🟢 no aliases and no orgs, sf org display -o foo

Error (2): Parsing --target-org
	No authorization information found for foo.
See more help with --help