Skip to content

Commit

Permalink
chore: delete exports for bundling workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
@mingxuanzhangsfdx
mingxuanzhangsfdx committed Apr 16, 2024
1 parent 7113764 commit c6615aa
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions scripts/updateForBundling.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ function updatePackageJson() {
delete packageJson.scripts.prepare;
}

// Remove 'exports'
if (packageJson.exports) {
delete packageJson.exports;
}

fs.writeFile(packagePath, JSON.stringify(packageJson, null, 2), 'utf8', (writeErr) => {
if (writeErr) {
console.error(`Error writing to package.json: ${writeErr}`);
Expand Down

3 comments on commit c6615aa

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: c6615aa Previous: 7113764 Ratio
Child logger creation 476995 ops/sec (±1.51%) 478747 ops/sec (±1.44%) 1.00
Logging a string on root logger 801359 ops/sec (±10.07%) 852584 ops/sec (±7.00%) 1.06
Logging an object on root logger 630787 ops/sec (±6.26%) 653742 ops/sec (±8.55%) 1.04
Logging an object with a message on root logger 9098 ops/sec (±204.35%) 30786 ops/sec (±182.00%) 3.38
Logging an object with a redacted prop on root logger 455560 ops/sec (±13.25%) 491172 ops/sec (±7.05%) 1.08
Logging a nested 3-level object on root logger 368030 ops/sec (±8.14%) 25126 ops/sec (±182.71%) 0.06827160829280221

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: c6615aa Previous: 7113764 Ratio
Logging an object with a message on root logger 9098 ops/sec (±204.35%) 30786 ops/sec (±182.00%) 3.38

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: c6615aa Previous: 7113764 Ratio
Child logger creation 339458 ops/sec (±0.28%) 345895 ops/sec (±0.46%) 1.02
Logging a string on root logger 781227 ops/sec (±10.49%) 845118 ops/sec (±7.80%) 1.08
Logging an object on root logger 572291 ops/sec (±6.79%) 622021 ops/sec (±6.18%) 1.09
Logging an object with a message on root logger 10076 ops/sec (±198.64%) 3012 ops/sec (±228.97%) 0.30
Logging an object with a redacted prop on root logger 420809 ops/sec (±8.99%) 449644 ops/sec (±12.21%) 1.07
Logging a nested 3-level object on root logger 317858 ops/sec (±5.10%) 332615 ops/sec (±6.60%) 1.05

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.