FIX (Extension) @W-17443055@ Fix smoke tests (#153)

.github/workflows/build-scanner-tarball.yml

@@ -6,7 +6,7 @@ on:
         description: "Which branch of the scanner should be built?"
         required: false
         type: string
-        default: "dev"
+        default: "dev-4"
 
 jobs:
   build-tarball:
@@ -25,9 +25,8 @@ jobs:
       - name: 'Check out, build, pack'
         run: |
           # Check out the target branch.
-          git clone https://github.com/forcedotcom/sfdx-scanner.git sfdx-scanner
+          git clone -b ${{ inputs.target-branch }} https://github.com/forcedotcom/sfdx-scanner.git sfdx-scanner
           cd sfdx-scanner
-          git checkout ${{ inputs.target-branch }}
           # Install and build dependencies.
           yarn
           yarn build

.github/workflows/daily-smoke-test.yml

@@ -4,25 +4,25 @@ on:
   schedule:
     # Cron syntax is "minute[0-59] hour[0-23] date[1-31] month[1-12] day[0-6]". '*' is 'any value', and multiple values
     # can be specified with comma-separated lists. All times are UTC.
-    # So this expression means "run at 13:30 UTC every day". This time was chosen because it corresponds to
-    # 8:30AM CDT, meaning that any issues will be surfaced towards the start of business.
-    - cron: "30 13 * * *"
+    # So this expression means "run at 17:30 UTC every day". This time was chosen because it corresponds to
+    # 9:30AM PST, meaning that any issues will be surfaced on working days when people are likely to be awake and online.
+    - cron: "30 17 * * 1-5"
 
 jobs:
   # Step 1: Build the scanner tarball so it can be installed locally.
   build-scanner-tarball:
     name: 'Build scanner tarball'
     uses: ./.github/workflows/build-scanner-tarball.yml
     with:
-      target-branch: 'dev'
+      target-branch: 'dev-4'
   # Step 2: Actually run the tests.
   smoke-test:
     name: 'Run smoke tests'
     needs: build-scanner-tarball
     uses: ./.github/workflows/run-tests.yml
     with:
       # For daily builds, we want to make sure we haven't pushed a breaking change
-      # to the scanner's `dev` branch.
+      # to the scanner's `dev-4` branch.
       use-scanner-tarball: true
   # Step 3: Build a VSIX artifact for use if needed.
   create-vsix-artifact:

.github/workflows/validate-pr.yml

@@ -21,7 +21,7 @@ jobs:
     name: 'Build scanner tarball'
     uses: ./.github/workflows/build-scanner-tarball.yml
     with:
-      target-branch: 'dev'
+      target-branch: 'dev-4'
   # Step 2: Actually run the tests.
   run_tests:
     name: 'Run unit tests'