Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change org logout commands and flags to sf style #5071

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

CristiCanizales
Copy link
Contributor

What does this PR do?

  • Updates Org Logout commands and flags to SF style in order to get rid of cli warnings

What issues does this PR fix or reference?

@W-14064806@

Changes

  • force:auth:logoutorg:logout
  • --noprompt--no-prompt
  • SFDX_JSON_TO_STDOUTSF_JSON_TO_STDOUT

Warnings before

16:16:46.686 sfdx force:auth:logout --all --noprompt
(node:49074) Warning: Deprecated environment variable: SFDX_JSON_TO_STDOUT. Please use SF_JSON_TO_STDOUT instead.
(Use `node --trace-warnings ...` to show where the warning was created)
Warning: The "force auth logout" command has been deprecated. Use "org logout" instead.
Warning: The "--noprompt" flag has been deprecated. Use "--no-prompt | -p" instead.

@CristiCanizales CristiCanizales requested a review from a team as a code owner September 3, 2023 19:05
@CristiCanizales CristiCanizales requested review from lukeis, RitamAgrawal and daphne-sfdc and removed request for lukeis September 3, 2023 19:05
@CristiCanizales CristiCanizales self-assigned this Sep 3, 2023
@daphne-sfdc daphne-sfdc self-requested a review September 18, 2023 13:52
Copy link
Contributor

@daphne-sfdc daphne-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🎉

@CristiCanizales CristiCanizales merged commit c72c9ed into develop Sep 20, 2023
@CristiCanizales CristiCanizales deleted the cristi/logout-warnings branch September 20, 2023 00:23
@daphne-sfdc
Copy link
Contributor

Here are the steps that I have gone through to test that the changes in this PR have removed the org logout warnings:

  1. Create a new project.
  2. Run “SFDX: Authorize an Org”. Authorize my dev org.
  3. Run “SFDX: Authorize a Dev Hub”. Authorize my dev org.
  4. Run “SFDX: Create a Default Scratch Org”.
  5. Run “SFDX: Authorize an Org”. Authorize [email protected].
  6. Run “SFDX: Set a Default Org”. Select the scratch org from the menu.
  7. Go to the Terminal and run “sf org list”. All three orgs have status Connected or Active.
  8. Run “SFDX: Log Out from Default Org”. ✅
  9. Go to the Terminal and run “sf org list”. Both remaining orgs have status Connected.
  10. Run “SFDX: Log Out from All Authorized Orgs”. ✅
  11. Go to the Terminal and run “sf org list”. No orgs are found.

While doing this testing, I did not see any warnings for the variables that were changed in this PR. Therefore, the org logout warnings are successfully removed in this code change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants