-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change org open commands and flags to sf style #5059
Conversation
@@ -66,15 +65,14 @@ import { | |||
forceSourceRetrieveCmp, | |||
forceSourceRetrieveManifest, | |||
forceSourceRetrieveSourcePaths, | |||
forceSourceStatus, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not used in the file, so I removed it
registerFunctionInvokeCodeLensProvider, | ||
SourceStatusFlags, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here. Not used
}; | ||
const flagStatusRemote: FlagParameter<SourceStatusFlags> = { | ||
flag: SourceStatusFlags.Remote | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here with these 2 above. Not used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! 🎉
Here are the steps that I have gone through to test that the changes in this PR have removed the org open warnings:
While doing this testing, I did not see any warnings for the variables that were changed in this PR. Therefore, the org open warnings are successfully removed in this code change. |
What does this PR do?
What issues does this PR fix or reference?
@W-14047044@
Changes
force:org:open
⇢org:open
--urlonly
⇢--url-only
SFDX_JSON_TO_STDOUT
⇢SF_JSON_TO_STDOUT
Warnings before