Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change org open commands and flags to sf style #5059

Merged
merged 7 commits into from
Sep 19, 2023

Conversation

CristiCanizales
Copy link
Contributor

What does this PR do?

  • Updates Org Open commands and flags to SF style in order to get rid of cli warnings

What issues does this PR fix or reference?

@W-14047044@

Changes

  • force:org:openorg:open
  • --urlonly--url-only
  • SFDX_JSON_TO_STDOUTSF_JSON_TO_STDOUT

Warnings before

18:54:02.495 sfdx force:org:open
(node:85263) Warning: Deprecated environment variable: SFDX_JSON_TO_STDOUT. Please use SF_JSON_TO_STDOUT instead.
(Use `node --trace-warnings ...` to show where the warning was created)
Warning: The "force org open" command has been deprecated. Use "org open" instead.

@CristiCanizales CristiCanizales requested a review from a team as a code owner August 30, 2023 21:18
@CristiCanizales CristiCanizales requested review from gbockus-sf, RitamAgrawal and daphne-sfdc and removed request for gbockus-sf August 30, 2023 21:18
@CristiCanizales CristiCanizales self-assigned this Aug 30, 2023
@@ -66,15 +65,14 @@ import {
forceSourceRetrieveCmp,
forceSourceRetrieveManifest,
forceSourceRetrieveSourcePaths,
forceSourceStatus,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not used in the file, so I removed it

registerFunctionInvokeCodeLensProvider,
SourceStatusFlags,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here. Not used

};
const flagStatusRemote: FlagParameter<SourceStatusFlags> = {
flag: SourceStatusFlags.Remote
};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here with these 2 above. Not used

Copy link
Contributor

@daphne-sfdc daphne-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🎉

@CristiCanizales CristiCanizales merged commit 42a5d48 into develop Sep 19, 2023
@CristiCanizales CristiCanizales deleted the cristi/open-org-warnings branch September 19, 2023 21:58
@daphne-sfdc
Copy link
Contributor

Here are the steps that I have gone through to test that the changes in this PR have removed the org open warnings:

  1. Create a new project.

  2. Run “SFDX: Authorize an Org”. Authorize my dev org.
    a. Command Palette: Run “SFDX: Open Default Org”. Make sure my dev org is open. ✅
    b. Bottom Bar: Click the “Open Org” button. Make sure my dev org is open. ✅

  3. Run “SFDX: Authorize a Dev Hub”. Authorize my dev org.

  4. Run “SFDX: Create a Default Scratch Org”.
    a. Command Palette: Run “SFDX: Open Default Org”. Make sure the scratch org is open. ✅
    b. Bottom Bar: Click the “Open Org” button. Make sure the scratch org is open. ✅

  5. Run “SFDX: Log Out from All Authorized Orgs”.
    a. Command Palette: Run “SFDX: Open Default Org”. No org should be opened, and there should be a notification that says “SFDX: Open Default Org failed to run”. ✅
    b. Bottom Bar: Make sure the “Open Org” button is no longer present. ✅

While doing this testing, I did not see any warnings for the variables that were changed in this PR. Therefore, the org open warnings are successfully removed in this code change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants