Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change org login web commands and flags to sf style #5058

Merged
merged 6 commits into from
Sep 19, 2023

Conversation

CristiCanizales
Copy link
Contributor

@CristiCanizales CristiCanizales commented Aug 30, 2023

What does this PR do?

  • Updates Org Login commands and flags to SF style in order to get rid of cli warnings

What issues does this PR fix or reference?

@W-14046893@

Changes

  • auth:web:loginorg:login:web
  • auth:device:loginorg:login:device
  • --setdefaultdevhubusername--set-default-dev-hub
  • --setalias--alias
  • --instanceurl--instance-url
  • --setdefaultusername--set-default
  • --noprompt--no-prompt
  • SFDX_JSON_TO_STDOUTSF_JSON_TO_STDOUT

Warnings before

(node:51621) Warning: Deprecated environment variable: SFDX_JSON_TO_STDOUT. Please use SF_JSON_TO_STDOUT instead.
(Use `node --trace-warnings ...` to show where the warning was created)
Warning: The "force auth web login" command has been deprecated. Use "org login web" instead.
Warning: The "--setalias" flag has been deprecated. Use "--alias | -a" instead.
Warning: The "--instanceurl" flag has been deprecated. Use "--instance-url | -r" instead.
Warning: The "--setdefaultusername" flag has been deprecated. Use "--set-default | -s" instead.

@CristiCanizales CristiCanizales requested a review from a team as a code owner August 30, 2023 20:51
@CristiCanizales CristiCanizales requested review from klewis-sfdc, RitamAgrawal and daphne-sfdc and removed request for klewis-sfdc August 30, 2023 20:51
Copy link
Contributor

@daphne-sfdc daphne-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🎉

@CristiCanizales CristiCanizales merged commit 4fe78cb into develop Sep 19, 2023
@CristiCanizales CristiCanizales deleted the cristi/org-login-commands branch September 19, 2023 18:19
@daphne-sfdc
Copy link
Contributor

daphne-sfdc commented Sep 20, 2023

Here are the steps that I have gone through to test that the changes in this PR have removed the org login warnings:

  1. Create a new project.

  2. Command Palette:
    a. Run “SFDX: Authorize an Org”. Authorize my dev org. ✅
    b. Run “SFDX: Authorize a Dev Hub”. Authorize my dev org. ✅
    c. Run “SFDX: Create a Default Scratch Org”. ✅
    d. Run “SFDX: Set a Default Org”. Select my dev org from the menu. ✅

  3. Bottom Bar:
    a. Click on the alias of the currently authorized org to open the menu.
    b. Select “SFDX: Authorize an Org” from the menu. Authorize [email protected]. ✅
    c. Select “SFDX: Authorize a Dev Hub” from the menu. Authorize [email protected]. ✅
    d. Set my dev org as the default org. ✅
    e. Set the scratch org as the default org. ✅

  4. Go to the Terminal and run “sf org list”. All orgs have status Connected or Active. ✅

While doing this testing, I did not see any warnings for the variables that were changed in this PR. Therefore, the org login warnings are successfully removed in this code change.

@CristiCanizales CristiCanizales self-assigned this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants