Skip to content

Commit

Permalink
chore: Publish in Microsoft Marketplace and Publish in Open VSX Regis…
Browse files Browse the repository at this point in the history
…try GHA workflows will fail when extensions are not published (#5565)

* chore: try logging into the salesforce publisher

* chore: update to version 60.11.1

* chore: updated SHA256 v60.11.1 [skip ci]

* chore: comment out unnecessary parts of publishVSCode.yml workflow

* chore: npx vsce login salesforce instead  of vsce login salesforce

* chore: print result of publish

* chore: try removing find

* chore: use loop

* chore: use set -e

* chore: use -exec sh -c

* chore: clean up + change back to while loop

* chore: try Pete's one-liner suggestion

* chore: simplify shell script command

* chore: remove -o flag

* revert: revert back to Pete's suggestion

* Merge branch 'develop' of github.com:daphne-sfdc/salesforcedx-vscode-publish-microsoft-marketplace into daphne/W-15437641-publish-microsoft-marketplace

* chore: uncomment previously commented code in publishVSCode.yml

* chore: revert SHA256.md and lerna.json

* chore: add echo SUCCESSFULLY published

* chore: comment out extra steps in publishOpenVSX.yml

* fix: replace publish command in publishOpenVSX.yml

* fix: pass in OVSX_PAT as second %s argument

* fix: add placeholder braces

* chore: uncomment previously commented code in publishOpenVSX.yml

* chore: remove redundant echo SUCCESSFULLY published

---------

Co-authored-by: peternhale <[email protected]>
  • Loading branch information
daphne-sfdc and peternhale authored May 2, 2024
1 parent a39d59e commit 5846cae
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/publishOpenVSX.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ jobs:
- name: Display downloaded vsix files
run: ls -R ./extensions
- run: npm ci
- run: find ./extensions -type f -name "*.vsix" -exec npx ovsx publish {} -p ${{ env.OVSX_PAT }} \;
- run: echo "SUCCESSFULLY published"
- run: |
cmd=$(find ./extensions -type f -name "*.vsix" -print0 | xargs -0 -I {} printf 'npx ovsx publish "%s" -p "%s" && ' '{}' "${OVSX_PAT}" | sed 's/ && $//') && [ -n "$cmd" ] && eval "$cmd" && echo "SUCCESSFULLY published"
ctcCloseSuccess:
needs: [ctc-open, publish]
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publishVSCode.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ jobs:
- name: Display downloaded vsix files
run: ls -R ./extensions
- run: npm ci
- run: find ./extensions -type f -name "*.vsix" -exec npx vsce publish --pat ${{ env.VSCE_PERSONAL_ACCESS_TOKEN }} --packagePath {} \;
- run: echo "SUCCESSFULLY published"
- run: |
cmd=$(find . -type f -name "*.vsix" -print0 | xargs -0 printf 'npx vsce publish --pat "%s" --packagePath "%s" && ' "${VSCE_PERSONAL_ACCESS_TOKEN}" | sed 's/ && $//')&&[ -n "$cmd" ] && eval "$cmd" && echo "SUCCESSFULLY published"
ctcCloseSuccess:
needs: [ctc-open, publish]
Expand Down
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@
},
"useNx": true,
"useWorkspaces": true
}
}
2 changes: 1 addition & 1 deletion packages/system-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,4 @@
"activationEvents": [
"*"
]
}
}

0 comments on commit 5846cae

Please sign in to comment.