fix: eliminate "Cannot read properties of undefined (reading type)" e…

…rror (#5443) * fix: fix "Cannot read properties of undefined (reading type)" error * Pull in code review suggestion Co-authored-by: peternhale <[email protected]> * fix: move if statement to Line 289 --------- Co-authored-by: peternhale <[email protected]>
forcedotcom · Feb 22, 2024 · 56c7f3d · 56c7f3d
1 parent 2a4ef70
commit 56c7f3d
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/salesforcedx-vscode-core/src/commands/baseDeployRetrieve.ts b/packages/salesforcedx-vscode-core/src/commands/baseDeployRetrieve.ts
@@ -286,9 +286,11 @@ export abstract class RetrieveExecutor<T> extends DeployRetrieveExecutor<T> {
       const relativePackageDirs = await SfdxPackageDirectories.getPackageDirectoryPaths();
       const output = this.createOutput(result, relativePackageDirs);
       channelService.appendLine(output);
-      PersistentStorageService.getInstance().setPropertiesForFilesRetrieve(
-        result.response.fileProperties
-      );
+      if (result?.response?.fileProperties !== undefined) {
+        PersistentStorageService.getInstance().setPropertiesForFilesRetrieve(
+          result.response.fileProperties
+        );
+      }
     }
   }