Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates GHAs to align closer to the most recent versions #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iowillhoit
Copy link

@iowillhoit iowillhoit commented Jan 8, 2025

What does this PR do?
Updates GHAs to align closer to the most recent versions

Changes:

  • The create-github-release workflow replaces both onPushToMain and manualRelease
    • It looks like both create-github-release and onPushToMain have been running in tandem.
  • The onRelease changes supports prereleases better
  • Deleted one of the duplicate validate PR workflows
  • Removes duplicate testCommitExceptMain.yml in favor of tests.tml

What issues does this PR fix or reference?
[skip-validate-pr]

@@ -10,7 +10,7 @@ jobs:
steps:
- name: Notify Slack on PR open
env:
WEBHOOK_URL: ${{ secrets.CLI_TEAM_SLACK_WEBHOOK_URL }}
WEBHOOK_URL: ${{ secrets.IDEE_RELEASE_ALERT_SLACK_WEBHOOK }}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update if needed

@iowillhoit
Copy link
Author

Note that your Github Releases are being created by the svc-cli-bot. If you would rather have them publish with your SVC bot, the easiest way to do that would be to override the SVC_CLI_BOT_GITHUB_TOKEN secret with your bot's token (which is likely IDEE_GH_TOKEN) at the repo level (not the org level). For example here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant