NEW(pmd): @W-17310939@: Add in more AppExchange rules for XML language #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-carter-at-sf
force-pushed
the
sc/pmdAppExchange
branch
2 times, most recently
from
246441e to
ed71dad
Compare
stephen-carter-at-sf
changed the title
stephen-carter-at-sf
force-pushed
the
sc/pmdAppExchange
branch
from
ed71dad to
f7fbb8c
Compare
stephen-carter-at-sf
force-pushed
the
sc/pmdAppExchange
branch
from
f7fbb8c to
ee4763e
Compare
jfeingold35
reviewed
Dec 19, 2024
| NAMES OF THE FILES IN A SALESFORCE PROJECT. THIS RULE REALLY ISN'T ONE THAT SHOULD BE WRITTEN AS A PMD RULE IN | ||
| MY OPINION SINCE WHILE PROCESSING A *.field-meta.xml FILE IT ATTEMPTS TO ALSO LOOK AT AND PROCESS | ||
| *.object-meta.xml FILES AS WELL, WHICH THIS TYPE OF TESTING FRAMEWORK CAN'T HANDLE. | ||
| SO THE SECURITY TEAM WILL HAVE TO WRITE A CUSTOM TEST FOR THIS IF WE WANT COVERAGE FOR THIS RULE. |
There was a problem hiding this comment.
is this dependency being tracked?
There was a problem hiding this comment.
Yeah I have a list of all PMD AppExchange rules that we need to pull into code analyzer 5 and their statuses. This rule is marked as only being partially complete so far.
| // https://developer.salesforce.com/docs/atlas.en-us.api_meta.meta/api_meta/meta_remotesitesetting.htm | ||
| // specifies that .remoteSite is the file extension for remote site settings files. | ||
| '.remoteSite' | ||
| '.xml' |
There was a problem hiding this comment.
Dumb question: Do we have a way of enforcing that the rules are run against *-meta.xml files only, as opposed to all XML files?
There was a problem hiding this comment.
Not really.
There was a problem hiding this comment.
That's probably fine for now. But it might be worth considering in the future. It'd be annoying for a user if some totally unrelated XML file tripped a rule by accident.
jfeingold35
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.