Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deployment target to iOS 17 #3796

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

bbirman
Copy link
Member

@bbirman bbirman commented Jan 10, 2025

No description provided.

@@ -24,8 +24,8 @@ then
fi

# Check for Xcode minimum version
XCODE_MIN_VERSION=130
XCODE_MIN_VERSION_STR="Xcode 13.0"
XCODE_MIN_VERSION=160
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this and the readme got out of sync with the min version spreadsheet, assuming we want Xcode 16 for 13.0?

Copy link

1 Warning
⚠️ Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File Type Category Description Line Col
SFOAuthCoordinator Nullability Memory error nil assigned to a pointer which is expected to have non-null value 118 19
SalesforceSDKManager Nil value used as mutex for @synchronized() (no synchronization will occur) Logic error Nil value used as mutex for @synchronized() (no synchronization will occur) 143 5
SalesforceSDKManager Nil value used as mutex for @synchronized() (no synchronization will occur) Logic error Nil value used as mutex for @synchronized() (no synchronization will occur) 155 5

Generated by 🚫 Danger

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.76%. Comparing base (33923fa) to head (afb3498).
Report is 1259 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff            @@
##           dev    #3796       +/-   ##
========================================
+ Coverage     0   62.76%   +62.76%     
========================================
  Files        0      224      +224     
  Lines        0    21361    +21361     
========================================
+ Hits         0    13408    +13408     
- Misses       0     7953     +7953     
Components Coverage Δ
Analytics 84.09% <72.09%> (∅)
Common 68.87% <85.63%> (∅)
Core 51.62% <35.07%> (∅)
SmartStore 73.70% <ø> (∅)
MobileSync 87.58% <93.26%> (∅)
Files with missing lines Coverage Δ
...lesforceSDKCore/Classes/OAuth/SFOAuthCoordinator.m 39.93% <100.00%> (ø)

... and 205 files with indirect coverage changes

@bbirman
Copy link
Member Author

bbirman commented Jan 10, 2025

merging because the test failures are flappers, will make work items to investigate them more

@bbirman bbirman merged commit 9692ed2 into forcedotcom:dev Jan 10, 2025
11 of 12 checks passed
@bbirman bbirman deleted the 13-cleanup branch January 10, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants