-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for snapshot dismissal #3778
Conversation
[self.snapshotViewControllers removeObject:scene.session.persistentIdentifier]; | ||
} | ||
|
||
- (nullable UIScene *)sceneFromNotification:(NSNotification *)notification { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this to check the object on the notification more safely
Clang Static Analysis Issues
Generated by 🚫 Danger |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3778 +/- ##
==========================================
- Coverage 63.35% 63.13% -0.22%
==========================================
Files 227 227
Lines 21590 21736 +146
==========================================
+ Hits 13678 13723 +45
- Misses 7912 8013 +101
|
Merging because the failing test ( |
In #3679 I changed the notification we use to dismiss snapshot from
UISceneDidActivateNotification
toUISceneWillEnterForegroundNotification
becauseUISceneDidActivateNotification
isn't called for screen mirroring and I thoughtUISceneWillEnterForegroundNotification
could cover both cases. There's a new issue with usingUISceneWillEnterForegroundNotification
so this PR separates it into usingUISceneDidActivateNotification
for the main flow like it was originally andUISceneWillEnterForegroundNotification
for the non-interactive/mirrored case