Speedup large notebooks: fix cache miss in notebook_to_js
#2973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2958
We accidentally removed a caching system in 2183b0a#diff-def3c256c1eef2beff41b35619e1d28209bf7cbb56c223d408f6cf53ed98582dL139-R137 in 0.19.37 that led to a big slowdown in
notebook_to_js
for large notebooks.This brings the
notebook_to_js
time for a big notebook from250ms
to1.85ms
.I also changed the
notebook_to_js
to always use the cached topological order, even if a newer one is possible. Just because this fieldcell_execution_order
is not even used by us, it's just there for future experiments.