-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom name in @progress
(ProgressLogging.jl)
#2966
Conversation
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/disberd/Pluto.jl", rev="show_progress_name")
julia> using Pluto |
@fonsp I fine with either option, as the important part is to have the name displayed when it's actually provided in my opinion |
Nice! I didn't know about names but thats a very useful feature! I'm not sure about the sync icon, I feel like it's not necessary because a progress bar is familiar. Or do you think this needs to be communicated better? |
I just thought it felt strange not to have an icon when every other log had one, but I don't have a very strong opinion on this so we can also just ditch it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay! Let's remove the icon.
The rest looks good! Two tweaks you can make:
- remove the console log
- use the CSS
:empty
pseudo-class instead of calculating it yourself
Thanks so much! Sorry, my holiday got inbetween 🙈 |
This PR adds support for the visualization of custom names of progress bars created with
@progress
from ProgressLogging.I also added a small sync icon to the logs of ProgressLogging as there was no icon at the moment.
Before this PR
After the PR: