Show progress bar earlier during load #2889
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On very slow connections, you need to wait for the full editor JS to be loaded until you see the fetch progress bar.
This PR does some "server side rendering" to show an indeterminate progress bar immediately when the html and CSS loads, which will be "hydrated" when the editor JS is loaded.
Here is a "Fast 3G" throttled load of a featured notebook. Notice first the (greyed out) progress bar, replaced by the real progress bar, and once the statefile is loaded, the notebook. Before this PR, you would see a blank screen.
Schermopname.2024-04-09.om.12.57.32.mov