Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show progress bar earlier during load #2889

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Apr 9, 2024

On very slow connections, you need to wait for the full editor JS to be loaded until you see the fetch progress bar.

This PR does some "server side rendering" to show an indeterminate progress bar immediately when the html and CSS loads, which will be "hydrated" when the editor JS is loaded.

Here is a "Fast 3G" throttled load of a featured notebook. Notice first the (greyed out) progress bar, replaced by the real progress bar, and once the statefile is loaded, the notebook. Before this PR, you would see a blank screen.

Schermopname.2024-04-09.om.12.57.32.mov

@fonsp fonsp added frontend Concerning the HTML editor performance publishing Notebooks as static documents on the web labels Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="earlier-progress-bar-during-load")
julia> using Pluto

@fonsp fonsp merged commit 50582a1 into main Apr 9, 2024
4 checks passed
@fonsp fonsp deleted the earlier-progress-bar-during-load branch April 9, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Concerning the HTML editor performance publishing Notebooks as static documents on the web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant