Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No autocomplete in do arguments and variable names #2872

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Mar 29, 2024

Schermopname.2024-03-29.om.17.24.58.mov

I wasn't able to use the lezer parsed syntax tree for this because you often face this with incomplete expressions, like map(1:190) do xx which does not parse as a DoClause because of the missing end.

So it's just regex-based.

@fonsp fonsp added the frontend Concerning the HTML editor label Mar 29, 2024
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="no-autocomplete-in-variable-names")
julia> using Pluto

@fonsp fonsp merged commit 971721e into main Mar 29, 2024
4 checks passed
@fonsp fonsp deleted the no-autocomplete-in-variable-names branch March 29, 2024 20:02
@fonsp fonsp added the autocomplete <TAB> label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocomplete <TAB> frontend Concerning the HTML editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant