🧾 Stack traces: code preview, URL, truncated, design #2813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the REPL:
New design
New design makes the stack trace look more inviting! It also adds more visual variety. There is also a title and some text to explain what it is.
Code previews
The most relevant frames are (often) those from your own code. In this PR, you get a small preview of the code from your notebook that made the call. You can click to jump to the line.
This is implemented without CodeMirror, but just with a
<pre>
and highlight.js to keep things simple :)URLs
You can now click on file locations from Julia Base, and it will send you to the source code on github :) Adding this functionality for stdlibs and remote packages would be nice! Working on this with @adrhill
Truncated stack trace
We search for the first frame that comes from this notebook, and all frames that came before it are hidden behind a More... button. This makes the stack trace less intimidating, and it is hopefully a good heuristic for "which frames are more useful?". It would be nice to add more heuristics.
Remove "top-level-scope"
Pretty technical, just removed the whole phrase, showing only the file:line.
TODO
More pictures