💩 Fix notebook saving issue (#277)

* some thingies

* back to plutoui 0.5.2 because i messed up the registry

* fix notebook saving bug

* bump

Project.toml

@@ -2,7 +2,7 @@ name = "Pluto"
 uuid = "c3e4b0f8-55cb-11ea-2926-15256bba5781"
 license = "MIT"
 authors = ["Fons van der Plas <[email protected]>", "Mikołaj Bochenski <[email protected]>"]
-version = "0.11.4"
+version = "0.11.5"
 
 [deps]
 Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"

README.md

@@ -127,7 +127,7 @@ The Pluto project is an ambition to [_rethink what a programming environment sho
 ### You can chat with us
 
 -   contact me (fonsi) **[via email](mailto:[email protected])** or on my <a href="https://meet.jit.si/Pluto.jl"><b>video chat room</b></a>
--   send your funky notebooks to the **[Zulip chat room](https://julialang.zulipchat.com/#narrow/stream/243342-pluto.2Ejl)**
+-   send your funky notebooks to the **[Zulip chat room](https://julialang.zulipchat.com/#narrow/stream/243342-pluto.2Ejl)** (_search for the `pluto.jl` stream_)
 -   use Pluto's **[built-in feedback system:](https://github.com/fonsp/Pluto.jl/issues/182#issue-637726414)**
 
 <img alt="feedback screencap" src="https://user-images.githubusercontent.com/6933510/84502876-6f08db00-acb9-11ea-84c3-f5daaba29273.png" width="100%">

frontend/components/Editor.js

@@ -587,6 +587,8 @@ export class Editor extends Component {
                     }
                     break
                 case 82: // r
+                    // I commonly have a test notebook that I want to re-run after changing something to the backend
+                    // if I would just reload the page, then the new Pluto session would be asked to open notebook with uuid=b1d2cbdb1c2bb12d, which does not exist in the new session
                     if (e.ctrlKey) {
                         if (this.state.notebook.path !== default_path) {
                             document.location.href = link_open(this.state.notebook)

frontend/editor.html

@@ -19,13 +19,13 @@
     <script src="common/RegisterSW.js"></script>
 
     <script src="https://cdn.jsdelivr.net/npm/@observablehq/[email protected]/dist/stdlib.js" defer></script>
-    <script src="https://cdn.jsdelivr.net/npm/codemirror@5.55.0/lib/codemirror.min.js" defer></script>
-    <script src="https://cdn.jsdelivr.net/npm/codemirror@5.55.0/mode/julia/julia.min.js" defer></script>
-    <script src="https://cdn.jsdelivr.net/npm/codemirror@5.55.0/addon/hint/show-hint.min.js" defer></script>
-    <script src="https://cdn.jsdelivr.net/npm/codemirror@5.55.0/addon/display/placeholder.min.js" defer></script>
-    <script src="https://cdn.jsdelivr.net/npm/codemirror@5.55.0/addon/edit/matchbrackets.min.js" defer></script>
-    <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/codemirror@5.55.0/lib/codemirror.min.css">
-    <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/codemirror@5.55.0/addon/hint/show-hint.min.css">
+    <script src="https://cdn.jsdelivr.net/npm/codemirror@5.56.0/lib/codemirror.min.js" defer></script>
+    <script src="https://cdn.jsdelivr.net/npm/codemirror@5.56.0/mode/julia/julia.min.js" defer></script>
+    <script src="https://cdn.jsdelivr.net/npm/codemirror@5.56.0/addon/hint/show-hint.min.js" defer></script>
+    <script src="https://cdn.jsdelivr.net/npm/codemirror@5.56.0/addon/display/placeholder.min.js" defer></script>
+    <script src="https://cdn.jsdelivr.net/npm/codemirror@5.56.0/addon/edit/matchbrackets.min.js" defer></script>
+    <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/codemirror@5.56.0/lib/codemirror.min.css">
+    <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/codemirror@5.56.0/addon/hint/show-hint.min.css">
 
 
     <link rel="stylesheet" href="editor.css" type="text/css" />

frontend/index.html

@@ -19,11 +19,11 @@
     <script src="common/RegisterSW.js"></script>
 
     <script src="https://cdn.jsdelivr.net/npm/@observablehq/[email protected]/dist/stdlib.js" defer></script>
-    <script src="https://cdn.jsdelivr.net/npm/codemirror@5.55.0/lib/codemirror.min.js" defer></script>
-    <script src="https://cdn.jsdelivr.net/npm/codemirror@5.55.0/addon/hint/show-hint.min.js" defer></script>
-    <script src="https://cdn.jsdelivr.net/npm/codemirror@5.55.0/addon/display/placeholder.min.js" defer></script>
-    <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/codemirror@5.55.0/lib/codemirror.min.css">
-    <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/codemirror@5.55.0/addon/hint/show-hint.min.css">
+    <script src="https://cdn.jsdelivr.net/npm/codemirror@5.56.0/lib/codemirror.min.js" defer></script>
+    <script src="https://cdn.jsdelivr.net/npm/codemirror@5.56.0/addon/hint/show-hint.min.js" defer></script>
+    <script src="https://cdn.jsdelivr.net/npm/codemirror@5.56.0/addon/display/placeholder.min.js" defer></script>
+    <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/codemirror@5.56.0/lib/codemirror.min.css">
+    <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/codemirror@5.56.0/addon/hint/show-hint.min.css">
 
 
     <link rel="stylesheet" href="index.css">

sample/PlutoUI.jl

@@ -280,10 +280,10 @@ md"In the future, Pluto might do this automatically for all packages. The goal i
 dog_url = "https://upload.wikimedia.org/wikipedia/commons/thumb/1/15/Welsh_Springer_Spaniel.jpg/640px-Welsh_Springer_Spaniel.jpg"
 
 # ╔═╡ 9ac7921c-c75e-11ea-30f5-c35e6ee370cb
-t_rex_url = "https://interactive-examples.mdn.mozilla.net/media/examples/t-rex-roar.mp3"
+t_rex_url = "https://upload.wikimedia.org/wikipedia/commons/transcoded/6/62/Meow.ogg/Meow.ogg.mp3"
 
 # ╔═╡ a8c57442-c75e-11ea-1913-7d82cbd2c69c
-flower_url = "https://interactive-examples.mdn.mozilla.net/media/examples/flower.webm"
+flower_url = "https://upload.wikimedia.org/wikipedia/commons/4/41/Sunflower_Flower_Opening_Time_Lapse.ogv"
 
 # ╔═╡ f743076c-cc57-11ea-1a8e-8799d9db985a
 
@@ -341,10 +341,9 @@ begin
 		import Pkg
 		Pkg.activate(env)
 		Pkg.update()
-		Pkg.add(Pkg.PackageSpec(;name="PlutoUI", version=v"0.5.1"))
+		Pkg.add(Pkg.PackageSpec(;name="PlutoUI", version=v"0.5.2"))
 	end
-	import PlutoUI
-	import PlutoUI: Slider, NumberField, CheckBox, TextField, Select, Button, FilePicker, Clock, DownloadButton, Resource, LocalResource
+	using PlutoUI
 end
 
 # ╔═╡ 34ebf81e-c760-11ea-05bb-376173e7ed10

src/webserver/Dynamic.jl

@@ -128,7 +128,8 @@ end
 responses[:run_multiple_cells] = (session::ServerSession, body, notebook::Notebook; initiator::Union{Initiator,Missing}=missing) -> let
     indices = cell_index_from_id.([notebook], UUID.(body["cells"]))
     cells = [notebook.cells[i] for i in indices if i !== nothing]
-    update_save_run!(session, notebook, cells; run_async=true, save=false)
+    # save=true fixes the issue where "Submit all changes" or `Ctrl+S` has no effect.
+    update_save_run!(session, notebook, cells; run_async=true, save=true)
 end
 
 responses[:getinput] = (session::ServerSession, body, notebook::Notebook, cell::Cell; initiator::Union{Initiator,Missing}=missing) -> let