Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIREC-412 Update 'Send claim' action to use pieces.send-claims interface #624

Merged
merged 3 commits into from
Dec 25, 2024

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Dec 23, 2024

Purpose

https://folio-org.atlassian.net/browse/UIREC-412

This pull request updates the 'Send claim' action in the ui-receiving module to utilize the pieces.send-claims interface, aligning with the latest backend changes.

Approach

The approach taken in this pull request focuses on maintaining compatibility with updated backend interfaces, improving code quality, and ensuring seamless integration with the pieces.send-claims interface. Here's a breakdown of the approach:

1. Alignment with Backend Updates

  • Objective: Ensure that the 'Send claim' action adheres to the new backend interface (pieces.send-claims).
  • Implementation:
    • Modified the logic of the 'Send claim' functionality to interact with the updated backend interface.
    • Updated API calls and payload structures as needed to comply with the pieces.send-claims specifications.

2. Code Refactoring

  • Objective: Enhance maintainability and readability of the codebase.
  • Implementation:
    • Refactored components and logic handling the 'Send claim' action to reduce complexity and improve modularity.
    • Removed redundant or obsolete code that was no longer compatible with the new backend structure.

Screenshots

chrome_Omk1fvISLw.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@usavkov-epam usavkov-epam self-assigned this Dec 23, 2024
Copy link

github-actions bot commented Dec 23, 2024

Jest Unit Test Statistics

282 tests   - 8   280 ✔️  - 8   3m 26s ⏱️ ±0s
  92 suites  - 3       2 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 7841abd. ± Comparison against base commit 259506b.

This pull request removes 10 and adds 2 tests. Note that renamed tests count towards both.
DelayClaimModal should call "onCancel" when the modal dismissed ‑ DelayClaimModal should call "onCancel" when the modal dismissed
DelayClaimModal should render delay claim modal ‑ DelayClaimModal should render delay claim modal
DelayClaimModal should submit valid form ‑ DelayClaimModal should submit valid form
DelayClaimModal should validate "Delay to" field ‑ DelayClaimModal should validate "Delay to" field
PieceForm Actions should handle "Send claim" action ‑ PieceForm Actions should handle "Send claim" action
SendClaimModal should call "onCancel" when the modal dismissed ‑ SendClaimModal should call "onCancel" when the modal dismissed
SendClaimModal should render send claim modal ‑ SendClaimModal should render send claim modal
SendClaimModal should submit valid form ‑ SendClaimModal should submit valid form
SendClaimModal should validate "Claim expiry date" field ‑ SendClaimModal should validate "Claim expiry date" field
getClaimingIntervalFromDate should return claiming interval calculated based on provided date ‑ getClaimingIntervalFromDate should return claiming interval calculated based on provided date
PieceFormContainer should handle "Send claim" action with claiming integration ‑ PieceFormContainer should handle "Send claim" action with claiming integration
PieceFormContainer should handle "Send claim" action without claiming integration ‑ PieceFormContainer should handle "Send claim" action without claiming integration

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 23, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 7841abd. ± Comparison against base commit 259506b.

♻️ This comment has been updated with latest results.

@usavkov-epam usavkov-epam requested review from a team December 24, 2024 06:12
@usavkov-epam usavkov-epam merged commit 2331c3f into master Dec 25, 2024
6 checks passed
@usavkov-epam usavkov-epam deleted the UIREC-412 branch December 25, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants