UIREC-362 Hide 'Add piece' action when related order has 'Pending' status and 'Synchronized' workflow #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atus and 'Synchronized' workflow
azizjonnurov
approved these changes
Dec 18, 2024
SerhiiNosko
reviewed
Dec 19, 2024
| const expectedPiecesProtectedActions = useMemo(() => ({ | ||
| [EXPECTED_PIECES_ACTION_NAMES.addPiece]: ( | ||
| restrictions?.protectCreate | ||
| || (isOrderPending && poLine.checkinItems === false) |
There was a problem hiding this comment.
Just for information, BE has the same validation rule to protect API users as well:
https://github.com/folio-org/mod-orders/pull/1068/files#diff-985428c1f8fca514c862e5313f72e1e5e22f9aff6f1d16f8bdede16e210f829bR49
SerhiiNosko
approved these changes
Dec 19, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://folio-org.atlassian.net/browse/UIREC-362
Approach
Declaratively hide and disable expected pieces' actions.
Screenshots
chrome_HVI7Xm6DA3.mp4
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.