Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIREC-393: refactor: additional locations and prevent loading behavior for adding pieces #587

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

alisher-epam
Copy link
Contributor

Purpose

UIREC-393: fix: the newly selected locations selection issuefocusedCommentId=228905

Approach

Screen.Recording.2024-09-25.at.20.30.44.mp4

Screenshots

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

Copy link

github-actions bot commented Sep 25, 2024

Jest Unit Test Statistics

288 tests  ±0   286 ✔️ ±0   3m 37s ⏱️ +17s
  96 suites ±0       2 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit b1b86d5. ± Comparison against base commit e228537.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 25, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit b1b86d5. ± Comparison against base commit e228537.

♻️ This comment has been updated with latest results.

Copy link

@alisher-epam alisher-epam requested review from usavkov-epam and a team September 25, 2024 15:43
@alisher-epam alisher-epam self-assigned this Sep 25, 2024
@alisher-epam alisher-epam merged commit e7bc232 into master Sep 25, 2024
6 checks passed
@alisher-epam alisher-epam deleted the UIREC-393 branch September 25, 2024 18:37
@usavkov-epam
Copy link
Contributor

Please wait for 2 approvals before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants