UIREC-291: add dropdown action buttons #468

alisher-epam · 2023-12-12T09:29:16Z

Purpose

UIREC-291 - Combine piece action buttons into action menu

Approach

Screen.Recording.2023-12-13.at.4.55.49.PM.mov

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

I've added appropriate record to the CHANGELOG.md
Does this PR meet or exceed the expected quality standards?
- Code coverage on new code is 80% or greater
- Duplications on new code is 3% or less
- There are no major code smells or security issues
Does this introduce breaking changes?
- If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
- There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

What other modules will these changes impact?
Do JIRAs exist to update the impacted modules?
- If not, please create them
- Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
- Do they have all they appropriate links to blocked/related issues?
Are the JIRAs under active development?
- If not, contact the project's PO and make sure they're aware of the urgency.
Do PRs exist for these changes?
- If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

github-actions · 2023-12-12T09:31:55Z

Jest Unit Test Statistics

180 tests +5 179 ✔️ +5 2m 50s ⏱️ -1s
  56 suites +2     1 💤 ±0
    1 files ±0     0 ❌ ±0

Results for commit 1398cf8. ± Comparison against base commit 4543d7b.

This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.

AddPieceModal Create another piece should update footer btns when 'Create another' is active ‑ AddPieceModal Create another piece should update footer btns when 'Create another' is active

AddPieceModal Create another piece should update footer button when 'Create another' is active ‑ AddPieceModal Create another piece should update footer button when 'Create another' is active
ModalActionButtons should call `onSave` function when save button clicked ‑ ModalActionButtons should call `onSave` function when save button clicked
ModalActionButtons should render component ‑ ModalActionButtons should render component
getPieceActionMenus should return array of action menus ‑ getPieceActionMenus should return array of action menus
getPieceActionMenus should return empty array if status is not in PIECE_ACTIONS_BY_STATUS ‑ getPieceActionMenus should return empty array if status is not in PIECE_ACTIONS_BY_STATUS
getPieceActionMenus should return empty array if status is not provided ‑ getPieceActionMenus should return empty array if status is not provided

♻️ This comment has been updated with latest results.

github-actions · 2023-12-12T09:32:17Z

BigTest Unit Test Statistics

0 tests ±0 0 ✔️ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit 1398cf8. ± Comparison against base commit 4543d7b.

♻️ This comment has been updated with latest results.

src/TitleDetails/AddPieceModal/ModalActionButtons/ModalActionButtons.js

src/TitleDetails/AddPieceModal/ModalActionButtons/utils.js

src/TitleDetails/AddPieceModal/ModalActionButtons/constants.js

usavkov-epam · 2023-12-12T15:27:08Z

It seems that "Save and create another" not working after changes

usavkov-epam · 2023-12-12T15:28:25Z

chrome_S8ZMwxqk63.mp4

usavkov-epam · 2023-12-12T15:30:17Z

And I don't think we need "Delete" action for a new piece form

usavkov-epam · 2023-12-13T12:17:38Z

Since we have the new action for "Save & create another", "Save&close" button should always save a piece and close the modal. Currently after clicking "Save & create another", isCreateAnother state stays the same for the next piece modal: "save&close" btn change label (it must not), and after clicking just "save" it opens the modal again (we have separate action for that).

Saving flow has to be updated according to new requirements.

chrome_lPD4I6JE5k.mp4

alisher-epam · 2023-12-13T14:17:18Z

@usavkov-epam here is the screen record for fixing

Screen.Recording.2023-12-13.at.7.11.04.PM.mov

usavkov-epam · 2023-12-13T15:38:05Z

src/TitleDetails/AddPieceModal/AddPieceModal.js

    change('isCreateAnother', true);
-    onSave(e);
-  }, [change, onSave]);
+    handleSubmit();


what about the validation on abandoned holdings b57abfd#diff-3dc65bda5cd25a0bdfd88592bcb6c213a492a05738d4bda9e2bcac1352bac488R115
will it be applied for the "save & create another" action?

I've checked locally - it's not

usavkov-epam · 2023-12-14T06:43:49Z

src/TitleDetails/AddPieceModal/ModalActionButtons/ModalActionButtons.css

+  border-top-left-radius: 0;
+  margin-left: -1px;
+
+  &::before, &:focus::before {


UX of the dropdown btn should be the same as for other btns

usavkov-epam · 2023-12-14T06:53:00Z

src/TitleDetails/AddPieceModal/ModalActionButtons/ModalActionButtons.js

+        }}
+      >
+        <DropdownMenu data-role="menu">
+          {actionMenus}


why is it plural?

usavkov-epam · 2023-12-14T07:00:04Z

Please check both rtl and ltr directions:

sonarqubecloud · 2023-12-14T09:38:36Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

UIREC-291: add dropdown action buttons

40ec2f6

alisher-epam added 2 commits December 12, 2023 16:15

tests: add test cases

c4b12c9

tests: fix test case

1730281

alisher-epam requested review from usavkov-epam and a team December 12, 2023 11:53

OleksandrHladchenko1 approved these changes Dec 12, 2023

View reviewed changes

alisher-epam requested a review from a team December 12, 2023 12:20

UladzislauKutarkin approved these changes Dec 12, 2023

View reviewed changes

usavkov-epam assigned alisher-epam Dec 12, 2023

usavkov-epam requested changes Dec 12, 2023

View reviewed changes

alisher-epam added 2 commits December 13, 2023 16:49

refactor: update code quality and enable save & create another

3155428

hide delete button for new pieces

9a8225d

alisher-epam requested a review from usavkov-epam December 13, 2023 12:00

fix: set another piece issue

b57abfd

test: fix failing test

098d851

usavkov-epam reviewed Dec 13, 2023

View reviewed changes

Update AddPieceModal.js

fb677f4

alisher-epam requested a review from usavkov-epam December 13, 2023 19:07

usavkov-epam reviewed Dec 14, 2023

View reviewed changes

fix: dropdown button for rtl

ae42039

remove hover css styling

3718507

alisher-epam requested a review from usavkov-epam December 14, 2023 08:28

fix hover effect for action buttons

1398cf8

usavkov-epam approved these changes Dec 14, 2023

View reviewed changes

alisher-epam merged commit 6ad7fef into master Dec 14, 2023
6 checks passed

alisher-epam deleted the UIREC-291 branch December 14, 2023 09:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UIREC-291: add dropdown action buttons #468

UIREC-291: add dropdown action buttons #468

alisher-epam commented Dec 12, 2023 •

edited

Loading

github-actions bot commented Dec 12, 2023 •

edited

Loading

github-actions bot commented Dec 12, 2023 •

edited

Loading

usavkov-epam commented Dec 12, 2023

usavkov-epam commented Dec 12, 2023

usavkov-epam commented Dec 12, 2023

usavkov-epam commented Dec 13, 2023 •

edited

Loading

alisher-epam commented Dec 13, 2023

usavkov-epam Dec 13, 2023

usavkov-epam Dec 13, 2023

usavkov-epam Dec 14, 2023

usavkov-epam Dec 14, 2023

usavkov-epam commented Dec 14, 2023

sonarqubecloud bot commented Dec 14, 2023

UIREC-291: add dropdown action buttons #468

UIREC-291: add dropdown action buttons #468

Conversation

alisher-epam commented Dec 12, 2023 • edited Loading

Purpose

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

github-actions bot commented Dec 12, 2023 • edited Loading

Jest Unit Test Statistics

github-actions bot commented Dec 12, 2023 • edited Loading

BigTest Unit Test Statistics

usavkov-epam commented Dec 12, 2023

usavkov-epam commented Dec 12, 2023

usavkov-epam commented Dec 12, 2023

usavkov-epam commented Dec 13, 2023 • edited Loading

alisher-epam commented Dec 13, 2023

usavkov-epam Dec 13, 2023

Choose a reason for hiding this comment

usavkov-epam Dec 13, 2023

Choose a reason for hiding this comment

usavkov-epam Dec 14, 2023

Choose a reason for hiding this comment

usavkov-epam Dec 14, 2023

Choose a reason for hiding this comment

usavkov-epam commented Dec 14, 2023

sonarqubecloud bot commented Dec 14, 2023

Quality Gate passed

alisher-epam commented Dec 12, 2023 •

edited

Loading

github-actions bot commented Dec 12, 2023 •

edited

Loading

github-actions bot commented Dec 12, 2023 •

edited

Loading

usavkov-epam commented Dec 13, 2023 •

edited

Loading