UIREC-294 Check if a holding exists during the abandonment check #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
usavkov-epam
force-pushed
the
UIREC-294
branch
from
14c2cbe to
b31457e
Compare
|
Kudos, SonarCloud Quality Gate passed! |
alisher-epam
approved these changes
Oct 12, 2023
Dmytro-Melnyshyn
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://issues.folio.org/browse/UIREC-294
When a holding of a piece changes, a check is made to see if the current holding has connections with other items and/or pieces. The absence of links to the current holding implies a proposal to the user to delete or keep this holding. However, it may already have been deleted (as evidenced by the "invalid reference" label), so making additional checks to ensure that it will be abandoned is meaningless.
Approach
Check if a holding exists before analyzing if it will be abandoned after changing a piece holding.
Screenshots
chrome_7kRwQs4puU.mp4
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.