Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v5.0.1 #208

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Release v5.0.1 #208

merged 1 commit into from
Nov 26, 2024

Conversation

mariia-aloshyna
Copy link
Contributor

Update master branch after release

Copy link

github-actions bot commented Nov 25, 2024

Jest Unit Test Statistics

64 tests  ±0   64 ✔️ ±0   1m 4s ⏱️ -3s
16 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit a1f22a6. ± Comparison against base commit b672dbf.

♻️ This comment has been updated with latest results.

Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket description is "Release 5.0.1" but the code change bumps the version to 5.1.0. Is this really a release PR, or are you just pulling the release-changelog down onto master from the release branch?

If so, that's fine, but why would we bother publishing a patch-release with nothing except new tests? That seems odd.

@mariia-aloshyna
Copy link
Contributor Author

mariia-aloshyna commented Nov 25, 2024

The ticket description is "Release 5.0.1" but the code change bumps the version to 5.1.0. Is this really a release PR, or are you just pulling the release-changelog down onto master from the release branch?

If so, that's fine, but why would we bother publishing a patch-release with nothing except new tests? That seems odd.

hey Zak, this is about updating the master changelog after release, I put the Sunflower version to package.json.
Regarding tests - there are only 2 unit tests left and we planned to finish them in Sunflower but we managed to get it done already and the feature is completed, so PO suggested releasing it to Ramsons and closing the feature.

@mariia-aloshyna mariia-aloshyna merged commit ee7e0f7 into master Nov 26, 2024
5 checks passed
@mariia-aloshyna mariia-aloshyna deleted the release-v5.0.1 branch November 26, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants