[BUGFIX] Fix access to array key with array #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the foreach loop, $sysLanguageUid is not only the language uid, but an array, where the language uid is the key of the array. This fix separates the array from the key, so that $sysLanguageUid is only the key (and therefore the integer language uid). Resolves: fnagel#279
|
Interesting. Why am I not allowed to use $_? |
|
I think in this case it makes sense. Maybe we can just suppress it here? https://phpmd.org/documentation/suppress-warnings.html Using |
|
I have no idea why this checks are waiting for a PHP 7.3 run. Maybe I close and reopen the PR? |
|
Close and reopen in order to start the checks again... |
|
I don't get it. The PHP 7.3 check isn't even listed: https://github.com/fnagel/t3extblog/pull/280/checks |
|
After testing this locally, I will force merge it! |
|
Thanks, Felix! Forcing is always an option :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the foreach loop, $sysLanguageUid is not only the language uid, but an array, where the language uid is the key of the array. This fix separates the array from the key, so that $sysLanguageUid is only the key (and therefore the integer language uid).
Resolves: #279