Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add map_proj = 6 (Lat-lon) #221

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Conversation

matthiasdemuzere
Copy link
Contributor

A small test file is available here: geo_em.d04_map_proj6.zip

import salem
ifile = "geo_em.d04_map_proj6.nc"
ds = salem.open_xr_dataset(ifile)
ds.salem.quick_map('LU_INDEX')

@fmaussion fmaussion changed the base branch from master to dev September 6, 2022 08:55
@fmaussion
Copy link
Owner

Thanks a lot! Sorry for the long wait.

Instead of pushing to your master branch I will continue on dev and get this into the main branch soon!

@fmaussion fmaussion merged commit 236a8f0 into fmaussion:dev Sep 6, 2022
@fmaussion
Copy link
Owner

fmaussion commented Sep 6, 2022

OK so after reading a bit I'm still unclear why anyone would use this projection for regional applications. As implemented now, this code is only working for

pole_lat = 90
pole_lon = 0

The WRF docs say:

The cylindrical equidistant projection is required for global ARW simulations, although in its rotated aspect (i.e., when pole_lat, pole_lon, and stand_lon are changed from their default values) it can also be well-suited for regional domains anywhere on the earth’s surface.

Anyways, I'll add a check on POLE values and error if anything else than the regular pole since I can't test it.

@fmaussion
Copy link
Owner

Would you mind sending me the other 3 parent domains as well?

@fmaussion
Copy link
Owner

(and, ideally, the WPS config files that were used to generate these domains)

@matthiasdemuzere
Copy link
Contributor Author

geo_em.proj6_parents.zip

Unfortunately I do not have the WPS config files. I got these domains from a W2W user, for debugging purposes, and so I do not have any additional metadata or insights into the reasons this projection is used.

fmaussion added a commit that referenced this pull request Sep 6, 2022
* add map_proj = 6 (Lat-lon) (#221)

* add test and remove geogrid simulator

Co-authored-by: Matthias Demuzere <[email protected]>
@fmaussion
Copy link
Owner

OK, new release on PyPi: https://pypi.org/project/salem/0.3.8/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants