This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Log Links CloudWatch FluentD #292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Utsav Paul <[email protected]>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
|
@Smartmind12, thanks for creating the PR. But since the issue is assigned to a different person who created a PR already, I'm going to close this. |
|
@samhita-alla Was it not first PR submitted will be checked first kind of rule?? |
|
& also the other PR has the wrong command being commited so kindly reopen this PR! |
|
@Smartmind12, it is. When there are two PRs, I'll have to merge the one that has been fixed by the assignee. Also, what's wrong in the other PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Utsav Paul [email protected]
Type
Are all requirements met?
Complete description
Change the default template defined so that Log Links work with CloudWatch FluentD Out Of the Box
Tracking Issue
fixes flyteorg/flyte#2635