Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version flyte-binary helm chart and use flyte-binary-release docker images in releases #6010

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

eapolinario
Copy link
Contributor

Tracking issue

Discussed in slack.

Why are the changes needed?

flyte-binary image in helm chart is not versioned, which complicates the reproducibility.

What changes were proposed in this pull request?

This PR follows the pattern used by other images in helm charts, where at release time we point to images containing the -release suffix (e.g. https://artifacthub.io/packages/helm/flyte/flyte-core?modal=values).

How was this patch tested?

Ran scripts locally and validated the new versions in the flyte-binary values files.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.97%. Comparing base (da220be) to head (429c4ee).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6010   +/-   ##
=======================================
  Coverage   36.97%   36.97%           
=======================================
  Files        1312     1312           
  Lines      131525   131525           
=======================================
  Hits        48632    48632           
  Misses      78666    78666           
  Partials     4227     4227           
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.07% <ø> (ø)
unittests-flytecopilot 22.23% <ø> (ø)
unittests-flytectl 62.39% <ø> (ø)
unittests-flyteidl 7.05% <ø> (ø)
unittests-flyteplugins 53.83% <ø> (ø)
unittests-flytepropeller 43.10% <ø> (ø)
unittests-flytestdlib 55.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidmirror-ops davidmirror-ops merged commit 36f8c42 into master Nov 14, 2024
51 checks passed
@davidmirror-ops davidmirror-ops deleted the version-flyte-binary-image branch November 14, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants