Reference task to fetch latest version by default #5895
+89
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5895 +/- ##
==========================================
- Coverage 36.85% 33.03% -3.83%
==========================================
Files 1310 1013 -297
Lines 131246 107363 -23883
==========================================
- Hits 48377 35469 -12908
+ Misses 78670 68757 -9913
+ Partials 4199 3137 -1062
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
featherchen
force-pushed
the
issue-5825
branch
from
a06323d
to
044dd03
Compare
|
@eapolinario TestGetTask should work now, thanks @troychiu for the fix. |
Signed-off-by: featherchen <[email protected]>
Signed-off-by: featherchen <[email protected]>
Signed-off-by: featherchen <[email protected]>
Signed-off-by: featherchen <[email protected]>
featherchen
force-pushed
the
issue-5825
branch
6 times, most recently
from
35f91cc
to
7ff7fdc
Compare
featherchen
changed the title
Signed-off-by: featherchen <[email protected]>
featherchen
force-pushed
the
issue-5825
branch
from
7ff7fdc
to
fb6f97d
Compare
|
@troychiu Can you help me review this PR? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to #5825
Why are the changes needed?
When task version is not specified (i.e. ""), we should return the latest one when
getTaskis calledWhat changes were proposed in this pull request?
When the version is "", we fetch DB directly to get the latest task.
Also remove the UT that check whether version is empty, since this situation is allowed now.
How was this patch tested?
By unit test (testGetTask)
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link