Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(device_info_plus): unexpected , separator #3396

Closed
wants to merge 3 commits into from

Conversation

23doors
Copy link

@23doors 23doors commented Dec 12, 2024

Description

Fix for Package.swift which causes compilation errors on apps where swift package manager is enabled.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

  • No, this is not a breaking change.

@23doors
Copy link
Author

23doors commented Dec 12, 2024

similar issue in package_info_plus, added it as well

@miquelbeltran
Copy link
Member

Hey! Thanks for this fix. Can you check if the other projects also comply with this? Either we do one single PR with a fix for all plugins, or we do separated PRs per project.

@23doors
Copy link
Author

23doors commented Dec 12, 2024

@miquelbeltran to be honest, I'm not exactly sure if they comply fully and as I got 0 experience with swift package manager ;) I just had compilation errors with these 2 projects and figured it was just a simple syntax error in swift files. I checked all other Package.swift files in this project and got no complaints from the IDE like from these 2. So I guess, they should be fine?

In the end I had to turn off swift package manager for my app for now, as I had issues with csqlite package that I couldn't solve just yet. But after these 2 fixes in this PR, at least it compiled succesfully ;)

@vbuberen
Copy link
Collaborator

Thanks a lot for your contribution. I will give it a test a bit later today and merge it.

@vbuberen
Copy link
Collaborator

Once again thanks for catching the issue and opening a PR. In order to generate correct changelogs I created separate PRs for packages with your changes:
#3405
#3406

Thus, closing this PR in favor of those smaller ones.

@vbuberen vbuberen closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants