Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android_alarm_manager_plus): using super.key parameter to resolve linting issues #2690

Merged
merged 1 commit into from
Mar 15, 2024
Merged

chore(android_alarm_manager_plus): using super.key parameter to resolve linting issues #2690

merged 1 commit into from
Mar 15, 2024

Conversation

OutdatedGuy
Copy link
Contributor

Description

Using the recommended super.key parameter instead of the super() constructor in Widgets.

They do not pose any issue while using the package, but while fixing another issue in one of the packages I saw these linting warnings and thought of fixing them.

Related Issues

Trivial changes so doesn't need an issue.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions (this and the other PRs)!

I'll be taking a look at them and merging/closing them.

Meanwhile, please address the request for change I mentioned.

AUTHORS Show resolved Hide resolved
@miquelbeltran miquelbeltran changed the title refactor: using super.key parameter to resolve linting issues chore: using super.key parameter to resolve linting issues Mar 14, 2024
@miquelbeltran
Copy link
Member

miquelbeltran commented Mar 14, 2024

I would also need that the lint fixes are separated per package. If possible, one PR per package, so at the end there is one squashed commit per package.

@OutdatedGuy
Copy link
Contributor Author

I would also need that the lint fixes are separated per package. If possible, one PR per package, so at the end there is one squashed commit per package.

Trivial changes like this can be committed from a single PR across many packages as they surely does not break or change any working in the code.

Please check if having multiple PRs is really necessary and let me know what to do.

@miquelbeltran
Copy link
Member

Yes, we prefer if the PRs are per package because that facilitates generating changelogs.

@OutdatedGuy
Copy link
Contributor Author

Okay, fair enough reason 👍🏼

@OutdatedGuy OutdatedGuy changed the title chore: using super.key parameter to resolve linting issues chore(android_alarm_manager_plus): using super.key parameter to resolve linting issues Mar 15, 2024
@miquelbeltran
Copy link
Member

Waiting for CI to complete to merge

@miquelbeltran miquelbeltran merged commit 986b527 into fluttercommunity:main Mar 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants