Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1211
The serialization of
MandateDataCustomerAcceptance
was incorrect: In Stripe's API, it corresponds to a sealed union representing anonline
or anoffline
mandate. In Stripe's Android SDK, it's modelled the same way, though onlyonline
is supported. To maintain backwards compatibility, I kept the existing class structure and only added customfromJson(…)
andtoJson(…)
implementations, though a cleaner design would probably be a named constructorMandateDataCustomerAcceptance.online(…)
.The other problem was that
PaymentMethodType
was missing a PayPal variant, meaning the native SDK's result message couldn't be parsed.Now, payment and setup intents for subscriptions in Stripe are working for us both on Android and iOS with the following parameters: