Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use signed char in RISC-V 64bit #9524

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Oct 25, 2024

Same as other platforms, we have to use signed char even if RISC-V 64bit(riscv64).
For testing on RISCV64, we can also use uraimo/run-on-arch-action action to set up with riscv64 emulator with qemu.

In my visionfive RISC-V 64bit board, I succeeded to pass signedness sensitive tests which are flb-it-pack and flb-it-utils.
This is also causing problems on AArch64 Linux.
And there is also occurring on RISCV64 Linux.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@cosmo0920 cosmo0920 force-pushed the cosmo0920-riscv64-signed-char branch 2 times, most recently from d40fca6 to ec674fa Compare October 25, 2024 08:46
This is because this workflow is not injected and used clang packages

Signed-off-by: Hiroshi Hatake <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant