This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
Add shell: true option for modern Node/VSCode
#464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edemaine Please be aware that this repo is not actively monitored by the Flow team, and in the last week I have copied the source in the flow repo (facebook/flow@398144a) and will maintain it from there on ward. Therefore, we are likely to archive this repo soon. Do you mind to redo this change in the main flow repo and provide a test plan? |
facebook-github-bot
pushed a commit
to facebook/flow
that referenced
this pull request
Dec 16, 2024
Summary: As reported automatically in flow/flow-for-vscode#458, this plugin needs to engage the shell to launch the LSP on modern VSCode on Windows, because the script is generally installed as `flow-bin/cli.cmd` and only the shell can execute those. (port of flow/flow-for-vscode#464) Personally I still have issues using this plugin in my setup, because of the use of [`bin-version`](https://www.npmjs.com/package/bin-version) which calls [`execa`](https://github.com/sindresorhus/execa) which calls [`cross-spawn`](https://github.com/moxystudio/node-cross-spawn), which doesn't seem to support Flow via `yarn` on Windows (which creates `.js` files but no `.cmd`/.bat` file) — not sure exactly why. In the future, I'd suggest moving away from this rather heavy chain of dependencies. Let me know if you'd like a PR to that effect. Pull Request resolved: #9242 Reviewed By: SamChou19815 Differential Revision: D67295692 fbshipit-source-id: 68e7f68bb6e2593f3579e00a7bbf402b4be0f014
|
Closing since it has landed in the facebook/flow repo already |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #458 which is necessary for this plugin to work on modern VSCode on Windows.
Personally I still have issues using this plugin in my setup, because of the use of
bin-versionwhich callsexecawhich callscross-spawn, which doesn't seem to support Flow viayarnon Windows (which creates.jsfiles but no.cmd/.bat` file) — not sure exactly why.