Add shell: true option for modern VSCode on Windows
#9242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
SamChou19815
approved these changes
Dec 16, 2024
|
This pull request has been merged in 394ad79. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported automatically in flow/flow-for-vscode#458, this plugin needs to engage the shell to launch the LSP on modern VSCode on Windows, because the script is generally installed as
flow-bin/cli.cmdand only the shell can execute those.(port of flow/flow-for-vscode#464)
Personally I still have issues using this plugin in my setup, because of the use of
bin-versionwhich callsexecawhich callscross-spawn, which doesn't seem to support Flow viayarnon Windows (which creates.jsfiles but no.cmd/.bat` file) — not sure exactly why. In the future, I'd suggest moving away from this rather heavy chain of dependencies. Let me know if you'd like a PR to that effect.To test: simply run this extension in development on a Windows machine, and load any Flow project. It should work with this PR, but fail to load without it.