Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC Magic] Gen1 backdoor read support #228

Merged
merged 8 commits into from
Oct 19, 2024
Merged

[NFC Magic] Gen1 backdoor read support #228

merged 8 commits into from
Oct 19, 2024

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Jun 19, 2024 •
edited by skotopes
Loading

What's new

Verification

  • Try dumping a Gen1 magic tag, check that it is dumped correctly.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@mishamyte
Copy link

Hi @Astrrra,

Thank you for the implementation. I see that PR is opened, but have a chance to test it.
Feeling like all is fine, but keys have a reverse order (see screens, key on iKeyWhatever app is correct)
photo_2024-06-23_00-06-02
photo_2024-06-23_00-06-15

Thanks!

@Astrrra Astrrra marked this pull request as draft June 25, 2024 09:52
@Astrrra Astrrra mentioned this pull request Jun 25, 2024
Merged
3 tasks
@Astrrra
Copy link
Member Author

Astrrra commented Jun 25, 2024

@mishamyte you're right, thanks for pointing that out! Fixed now.

@Astrrra Astrrra marked this pull request as ready for review June 25, 2024 11:18
@skotopes skotopes merged commit a1e2913 into dev Oct 19, 2024
2 checks passed
@skotopes skotopes deleted the astra/gen1-dump branch October 19, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NFC Magic] Add support for backdoor read commands for Gen 1A/1B tags
3 participants
@Astrrra @mishamyte @skotopes