Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfc: Topaz read support #2688

Closed
wants to merge 17 commits into from
Closed

Conversation

GMMan
Copy link
Contributor

@GMMan GMMan commented May 22, 2023

Note: this is mostly intended for reference and accessibility for those who want this right now. Not anticipating this would be merged before the NFC refactor, and I'll make a new PR after that's done.

What's new

Verification

  • Use NFC read on Topaz 96 or 512 tag. It should be able to read the tag and show its 7-byte UID, HR0, and HR1 values.
  • Scanned tag should be saveable
  • Scanned tag should be loadable once saved
  • Scanned tag should have HR0 and HR1 showing in Info scene, and should show hex dump when "More" is selected on Info scene
  • Topaz should be selectable and usable from "Read Specific Card Type" menu
  • All other NFC tag types should work the same as before (regression check)

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@GMMan GMMan mentioned this pull request May 22, 2023
3 tasks
@hedger hedger added NFC NFC-related New Feature Contains an IMPLEMENTATION of a new feature labels May 22, 2023
@AloneLiberty AloneLiberty mentioned this pull request May 24, 2023
3 tasks
@gornekich
Copy link
Member

Hello @GMMan
Thanks for your PR. Unfortunately I don't have the samples to test it yet.
Since you are interested to add support of these cards, you can have a look at #2529 We added basic support for MfUltralight cards for new NFC architecture. Soon there will be iso-14443-4a poller ready and you can make PR with Topaz support to this branch.

I convert this PR to draft for now.

@skotopes skotopes marked this pull request as draft May 29, 2023 09:22
@gornekich
Copy link
Member

Hello @GMMan !
Recently we released new NFC stack in #3050 . I believe that new NFC API makes adding new protocols much easier.

Thanks for your PR! It would be perfect if you implement Topaz protocol on new NFC stack. In other case, we will do it but not in the nearest future. I will close this PR for now. If you have any questions please open Issue or contact me on Discord

@gornekich gornekich closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature Contains an IMPLEMENTATION of a new feature NFC NFC-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants