forked from technicalpickles/pager_duty-connection
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge in changes from the main repo and update for Rails 8 compatibilty #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recation Use updated Faraday syntax
…2.2.0 bump to 2.2.0
… non-JSON error responses
Add support for Unauthorized and Forbidden response codes, and handle non-JSON errors
Set HTTP GET body to nil, resolves technicalpickles#56
…2.3.0 Bump to 2.3.0
filter custom page query param from outgoing PD requests
Adds faraday 2 support, with backwards compatibility for faraday 1
…3.0.0 Version bump to 3.0.0
Use standardrb on everything
aellispierce
changed the title
Update with upstream
Merge in changes from the main repo and update for Rails 8 compatibilty
Jan 14, 2025
If I set this to only be a patch version, then updating to a higher patch would unexpectedly break this gem. There shouldn't be any breaking changes until the next major version. This also matches the pr to the main upstream repo.
bobbytables
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the fork to be up to date with the main upstream repo, removing our custom Faraday 2.X implementation in favor of the upstream one that was merged after ours.
The last commit, which bumps our activesupport dependency, is my only modification.