add logs to debug flaky test #795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swagatbora90
force-pushed
the
fix-flaky-test
branch
from
86e1ed8
to
a12e0c5
Compare
pendo324
previously approved these changes
Sep 26, 2024
pendo324
dismissed
their stale review
not meant to be merged, clicked approve by accident
swagatbora90
force-pushed
the
fix-flaky-test
branch
2 times, most recently
from
045308b
to
d6d1c8e
Compare
Signed-off-by: Swagat Bora <[email protected]>
swagatbora90
force-pushed
the
fix-flaky-test
branch
from
d6d1c8e
to
c4f03b2
Compare
henry118
reviewed
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
There are some tests that use
startAndWaitTaskcall to wait for the container exit and also capture the logs. Sometimes, containers will exit successfully but will return empty stdout. Adding logs to see if the containers logged anything to the stderr instead.Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.