Add support for firecracker snapshots #760
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CuriousGeorgiy
force-pushed
the
vhive-integration
branch
4 times, most recently
from
f6aaf67
to
6bcb731
Compare
The current network namespace parameter nested in the JailerConfig parameter requires specifying the entire jailer configuration, which is not convenient and doesn't allow using the noop jailer with a network namespace. To overcome this limitation, add a new NetNS parameter to the CreateVM request. See also a similar change in firecracker-microvm/firecracker-go-sdk#155. Signed-off-by: Georgiy Lebedev <[email protected]>
CuriousGeorgiy
force-pushed
the
vhive-integration
branch
4 times, most recently
from
09e74c6
to
9a7a2bd
Compare
In order to support firecracker snapshot-restore we need to make the following changes: * add a new CreateSnapshot request; * add new parameters for snapshot loading to the CreateVM request (following the firecracker Golang SDK design, snapshot loading is essentially creating a VM with additional snapshot options). When a VM is created by loading a snapshot, it's container snapshot drives are already mounted, so the drive mount stub creation and mounting is skipped. Also add a NetNS (network namespace) parameter to the CreateVM request, since the current NetNS parameter nested in the JailerConfig parameter requires specifying the entire jailer configuration, which is not convenient. Signed-off-by: Georgiy Lebedev <[email protected]>
CuriousGeorgiy
force-pushed
the
vhive-integration
branch
from
9a7a2bd
to
6f66aa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In order to support firecracker snapshots we need to make the following
changes:
(following the firecracker Golang SDK design, snapshot loading is
essentially creating a VM with additional snapshot options).
Also add a NetNS (network namespace) parameter to the CreateVM request,
since the current NetNS parameter nested in the JailerConfig parameter
requires specifying the entire jailer configuration, which is not
convenient.
Issue #, if available: #759
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.